Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removed metadata in orcidqueueconsumer #418

Open
wants to merge 1 commit into
base: main-cris
Choose a base branch
from

Conversation

floriangantner
Copy link

References

Add references/links to any related issues or PRs. These may include:

Description

in orcidqueueconsumer remove orcidqueue entries for metadata have been removed, e.g. no metadata in entity points to profileItem anymore.

Instructions for Reviewers

see Issue for Details

List of changes in this PR:

  • additional methos which checks all orcidqueueentries of the entity being consumed
    • if they are still valid and would generate some orcidqueue entry
    • if not, than delete existing orcidqueueentries if it is some insert action record.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@floriangantner floriangantner changed the base branch from main-cris to dspace-cris-2023_02_x April 9, 2024 09:59
@floriangantner floriangantner changed the base branch from dspace-cris-2023_02_x to main-cris April 15, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entries remain in orcid queue when persons metadata are added and removed.
1 participant