Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve migration of community subscriptions: set dspace_object_id to community UUID / remove community_id #362

Open
wants to merge 4 commits into
base: dspace-cris-7
Choose a base branch
from

Conversation

saschaszott
Copy link

This PR handles community subscriptions managed in the subscription table: it adds the community UUID to column dspace_object_id. This corresponds to the way new community subscriptions in DS CRIS are managed.

Afterward the column community_id in the subscription table is removed. This column was added with DSpace CRIS based on DSpace 1.8.2.2 (https://github.com/4Science/DSpace/blob/dspace-5_x_x-cris/dspace-api/src/main/resources/org/dspace/storage/rdbms/sqlmigration/postgres/V1.8.2.2__DSpaceCRIS-subscription_database_schema.sql).

@corrad82-4s corrad82-4s self-requested a review August 8, 2023 10:26
@saschaszott
Copy link
Author

The in-depth analysis in issue #371 has shown that the table subscription does not have column community_id in a clean/fresh installation of DS CRIS 7. Therefore, it is crucial that changes in this PR do not affect clean/fresh installations of DS CRIS 7. In its current form, this PR does not consider this fact. It needs to be extended.

@saschaszott
Copy link
Author

To fix the problem mentioned in the comment below it is crucial that the Flyway script V1.8.2.2__DSpaceCRIS-subscription_database_schema.sql which was shipped with DS CRIS 5 (https://github.com/4Science/DSpace/blob/dspace-5_x_x-cris/dspace-api/src/main/resources/org/dspace/storage/rdbms/sqlmigration/postgres/V1.8.2.2__DSpaceCRIS-subscription_database_schema.sql) is added in org/dspace/storage/rdbms/sqlmigration/postgres.

CRIS installations which have already migrated to DS CRIS 7 need to apply the changes manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant