Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entries remain in orcid queue when persons metadata are added and removed. #416

Open
floriangantner opened this issue Jan 30, 2024 · 0 comments · May be fixed by #418
Open

entries remain in orcid queue when persons metadata are added and removed. #416

floriangantner opened this issue Jan 30, 2024 · 0 comments · May be fixed by #418
Labels
bug

Comments

@floriangantner
Copy link

Describe the bug
OrcidQueue entries are not removed from the orcid queue when some author has been added and removed in some short time span.

To Reproduce
Steps to reproduce the behavior:

  1. Given some Person A with Orcid and common settings enabled for pushing Publications
  2. Add Person A as author to some Publication
  3. Save - OrcidQueueConsumer should create some new orcid entry
  4. Remove Person A as author from Publication
  5. Save - OrcidQueueConsumer should do nothing.
  6. Push to Orcid
  7. The record is falsely pushed to Orcid

Expected behavior
For profile entities/sections the values are removed using some checksum/metadata signature.
For OrcidEntities (Funding, Publication) there is no equivalent yet.

We expect the OrcidQueue Consumer to check existing OrcidQueue entries for the entity and delete all Insert-Operations where the profile is not found among the metadata authority values anymore.

This can be achieved by some check in consumeEntities

DSpace/dspace-api/src/main/java/org/dspace/orcid/consumer/OrcidQueueConsumer.java

Line 184 in fe36309

which finds all orcidqueue entries for the entitiy and loops again through the list of metadata.

Related work
Should also affect the upstream DSpace implementation
@floriangantner floriangantner changed the title entries remain in orcid queue when persons are added and removed. entries remain in orcid queue when persons metadata are added and removed. Jan 30, 2024
@floriangantner floriangantner mentioned this issue Jan 30, 2024
Open
floriangantner added a commit to uniba-ub/DSpace that referenced this issue Jan 30, 2024
@floriangantner
consider removed metadata in orcidqueueconsumer
2ff0b1e 
4Science#416
@floriangantner floriangantner linked a pull request Jan 30, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

consider removed metadata in orcidqueueconsumer uniba-ub/DSpace
1 participant
@floriangantner