Add merge pull request method #750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reimplements closed #142 |
BenFradet
reviewed
Jan 14, 2022
There was a problem hiding this comment.
The implementation looks good overall, we could do with tests and documentation however
there is a small guide in http://47degrees.github.io/github4s/contributing#test 👍
|
There is no integration test for |
|
I can try to implement both tests by committing randomly generated file to test repo. |
|
The issue is that this will be a bit noisy for watchers of the repo, however I think we can add some unit tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://docs.github.com/en/rest/reference/pulls#merge-a-pull-request