Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the Animation class, the
get_all_mobjects_to_update
method would cause duplicate Mobjects to be returned, and update was performed on all of them.Proposed changes
Add
items = list(set(items))
in theget_all_mobjects_to_update
method of the Animation class to achieve the purpose of removing duplicate items.Code and test
After running the above code, the Earth in the video will first rotate quickly and then decelerate. This is due to the get_all_mobjects_to_update method (TransForm.get_all_mobjects) in the Animation class returning duplicate mobjects(TransForm.get_all_mobjects.target_copy).
default.mp4
Therefore, I used the set function in the get_all_mobjects_to_update method of the Animation class to remove duplicate mobjects, which prevented the issue from occurring(fixed video)
default.mp4