Add rmpv::ext::to_value_named to keep struct keys #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `rmpv::ext::to_value` implementation turns Structs into `Value::Array<Value::String>` which is not deserializable by other languages. Technically I would call this a bug and opt to change the existing `to_value` implementation, but to stay cautious of not breaking existing users' code I think it makes sense to introduce a new `to_value_named` fn which instead turns Structs into `Value::Map` and maintains their keys.
jtt
reviewed
Jan 18, 2024
| where T: Serialize | ||
| { | ||
| ser::SerializeSeq::serialize_element(self, value) | ||
| self.map.push((to_value(key)?, to_value(value)?)); |
There was a problem hiding this comment.
You might want to call to_value_named(value) for value here if named is set to true to ensure any struct values get serialised with key names.
Similar kind of refactoring needs to be done for SerializeVec, DefaultSerializeMap etc. to ensure any struct values are encoded with key names if Serializer has named_structs set to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
rmpv::ext::to_valueimplementation turns Structs intoValue::Array<Value::String>which is not deserializable by other languages.Technically I would call this a bug and opt to change the existing
to_valueimplementation, but to stay cautious of not breaking existing users' code I think it makes sense to introduce a newto_value_namedfn which instead turns Structs intoValue::Mapand maintains their keys.Fixes #190