Don't use !indisvalid indexes for conflict resolution. #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading !indisready indexes, their structural defects may elicit low-level errors, as seen in the new test coverage. While we must skip those, !indisvalid indexes don't have that problem and could be better than no index. Nonetheless, follow the server's infer_arbiter_indexes() in skipping !indisvalid indexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading !indisready indexes, their structural defects may elicit low-level errors, as seen in the new test coverage. While we must skip those, !indisvalid indexes don't have that problem and could be better than no index. Nonetheless, follow the server's infer_arbiter_indexes() in skipping !indisvalid indexes.
The test change complicates an existing test rather than setting up a new one.
That saves a bit of test code and runtime. If you're prefer greater separation,
let me know.