Maintain indexes when updating pglogical.sequence_state. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmisch
force-pushed
the
sequence_state_pkey
branch
from
8a77e29
to
7e62ffb
Compare
The first non-HOT update corrupted the primary key index. This did not affect ordinary operations, because pglogical's own scans of pglogical.sequence_state are all sequential scans. The amcheck extension does witness the problem. Manual queries of sequence_state, albeit not a documented or otherwise expected use case, could return wrong answers.
nmisch
force-pushed
the
sequence_state_pkey
branch
from
7e62ffb
to
605e4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first non-HOT update corrupted the primary key index.
The heapallindexed() implementation comes from:
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=5184932432