fix deadlock during waiting for apply worker stop (issue #258) #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisRazinkin
changed the title
DenisRazinkin
commented
Oct 26, 2020
| if (apply->proc->waitLock) | ||
| { | ||
| const LOCKTAG apply_lock_tag = apply->proc->waitLock->tag; | ||
| if (((LockTagType) apply_lock_tag.locktag_type == LOCKTAG_TRANSACTION) && |
There was a problem hiding this comment.
This check works only for 2 processes deadlock cycle (apply worker and drop sub process).
PostgreSQL deadlock detection ( DeadLockCheck(PGPROC *proc) ) is not working here because drop subscription worker do not locked by apply worker, it just waiting for apply being stopped.
And ReleaseDeletionLock which we implement statically. Later we'll want to move them to compat, or better, rething the pglogical_depedency module completely.
# Conflicts: # Makefile # expected/init.out # pglogical.h
…ogical into REL2_x_STABLE
pglogical features: initial sync with clear filter, queue fix, queries executed after initial sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.