[5.3] MSTR-281: Fix issue where payload changed for API "phone_number…

…s" API (#1132) * MSTR-281: Fix issue where 'numbers.get' payload changed * Add changes suggested in code review
2600hz · Apr 5, 2024 · ea7eea9 · ea7eea9
1 parent fce7cdc
commit ea7eea9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/apps/common/submodules/numberMessaging/numberMessaging.js b/src/apps/common/submodules/numberMessaging/numberMessaging.js
@@ -114,7 +114,7 @@ define(function(require) {
 		numberMessagingFormatData: function(args) {
 			var self = this,
 				numberData = args.numberData,
-				settings = _.get(numberData, '_read_only.features.settings', {});
+				settings = _.get(numberData, 'metadata.features.settings', {});
 
 			return {
 				features: _.map(['sms', 'mms'], function(feature) {

diff --git a/src/apps/common/submodules/numberRenameCarrier/numberRenameCarrier.js b/src/apps/common/submodules/numberRenameCarrier/numberRenameCarrier.js
@@ -40,10 +40,10 @@ define(function(require) {
 					carriers: carriers
 				};
 
-			if (dataNumber.hasOwnProperty('_read_only') && dataNumber._read_only.hasOwnProperty('carrier_module')) {
+			if (dataNumber.hasOwnProperty('metadata') && dataNumber.metadata.hasOwnProperty('carrier_module')) {
 				_.each(carriers, function(carrier) {
-					if (dataNumber._read_only.carrier_module === carrier.key) {
-						formattedData.selectedCarrier = dataNumber._read_only.carrier_module;
+					if (dataNumber.metadata.carrier_module === carrier.key) {
+						formattedData.selectedCarrier = dataNumber.metadata.carrier_module;
 					}
 				});
 

diff --git a/src/apps/common/submodules/numbers/numbers.js b/src/apps/common/submodules/numbers/numbers.js
@@ -1936,6 +1936,8 @@ define(function(require) {
 					phoneNumber: phoneNumber
 				},
 				success: function(_data, status) {
+					_data.data['metadata'] = _.get(_data, 'metadata', {});
+
 					success && success(_data.data);
 				},
 				error: function(_data, status) {