Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Start super crude dirty checks for brainstorming #741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

munen
Copy link
Collaborator

@munen munen commented Nov 3, 2021

This is an idea for an approach to tackle #743 without introducing a big refactoring to how the synchronization currently happens.

Idea:

  • Count the number of actions that have dirtying effects
  • If, during an actual sync, new dirtying effects have taken place, do not set the isDirty flag to false

There's certainly better ways to handle all of the sync topic. But this could be an easy to build fix.

@munen munen self-assigned this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant