Add subtitle mode (videoplayer-like displaying), fix parsing SRT and refactor #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this repository while looking for subtitles plugin for my accessibility workshop. I liked that you use SRT format, as I was looking for something that could be used in cutscenes. However, I realized that it's not using the data as videoplayers do and instead of creating my own version from scratch I decided do build on top of your project and give my changes back.
It started small, but in the end git diff will not be useful to finding out what the changes are. So, to sum up in few points:
"TimeOnly"
parameter.Animation
orbool
orDictionary
.Feel free to take whatever you feel fitting. I know it's a lot for a single PR, but I didn't want to create multiple PRs with different changes, as most parts were interconnected due to refactor. You can check separate commits I did to see how it progressed.
There are some parts I would change even more but I have to move on with the workshop and leave reafactoring for now.