Удалено дублирование тестового метода updateCommonModule, в пакет добавлено check #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DoublesunRUS
commented
Aug 3, 2021
DoublesunRUS
commented
- Для того чтобы убрать дублирование метода updateCommonModule, он вынесен в отдельный тестовый абстрактный класс. Все тестовые классы, которые используют этот метод, сделаны его наследниками.
- В названии пакета тестового класса было пропущено слово check.
marmyshev
requested changes
Sep 18, 2021
| @@ -110,7 +101,7 @@ public void testTypeServerCallCorrect() throws Exception | |||
|
|
|||
| String fqn = "CommonModule.CommonServerCall"; | |||
|
|
|||
| updateCommonModule(dtProject, fqn, CommonModuleType.TYPE_SERVER_CALL); | |||
| updateCommonModule(dtProject, fqn, CommonModuleType.TYPE_SERVER_CALL, null, null); | |||
There was a problem hiding this comment.
Вызов выглядит очень непонятно! Почему тут можно null и почему нужно столько null указывать?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.