Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

[WIP] Add jasmine to travis #636

Closed
wants to merge 8 commits into from
Closed

[WIP] Add jasmine to travis #636

wants to merge 8 commits into from

Conversation

gemfarmer
Copy link
Contributor

For #628
Adds the jasmine:ci to travis.

Updates jasmine tests to pass.

@gemfarmer gemfarmer changed the title [WIP] Jasmine travis [WIP] Add jasmine to travis May 31, 2016
@@ -227,6 +227,16 @@
}
},
create: {
// Creates a scatterplot with a connecting sparkline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally prefer clear code over code comments because inevitably someone will change the code without updating the codes. Any way we could update this js to make it clearer / mitigate need for code comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the names need some refactoring. It feels quite a bit outside the scope of this PR. Why don't I just remove the comment for now, and create a naming issue for later refactoring?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works for me!

@jessieay
Copy link
Contributor

looks like jasmine test are running on travis!! woot woot

sadly, they are failing

@gemfarmer
Copy link
Contributor Author

@jessieay I got pulled into some EITI stuff, so I'll take a look at it today. Running rake jasmine the tests run fine, but jasmine:ci isn't accessing the mock data for some reason, so the tests are failing :(

@gemfarmer
Copy link
Contributor Author

gemfarmer commented Jun 2, 2016

Update: I passed the mock data directly to the previous_winners_spec.js variable (instead of referencing it from a helper file). The issues continued to exist while running rake jasmine:ci.

So why am I getting this error (below)? jasmine:ci runs phantomjs as a headless browser, so I figured that that might be the issue. Sure enough, there are several reported issues with similar errors

TypeError: undefined is not a constructor

@jessieay
Copy link
Contributor

jessieay commented Jun 2, 2016

Closing this in favor of #659

@jessieay jessieay closed this Jun 2, 2016
@jessieay jessieay deleted the jasmine-travis branch June 2, 2016 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants