Remove unused YML file flatten helpers #10579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Used to help address merge conflicts and streamline transition to flattened YML files, but should not be needed after changelog: Internal, Source code, Remove unused scripts
zachmargolis
commented
May 9, 2024
There was a problem hiding this comment.
maybe we might keep this one? If we ever convert other codebases or receive whole files that are the old-style, this could be useful to convert?
On the other hand, it's not that complicated of a script and it will live on in git history
There was a problem hiding this comment.
Yeah I think we could find it easily enough in git history if we needed it for some future effort like that.
aduth
approved these changes
May 10, 2024
There was a problem hiding this comment.
Yeah I think we could find it easily enough in git history if we needed it for some future effort like that.
|
We no longer have any outstanding PRs that use the old style, I'm going to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(do not merge until outstanding PRs with i18n updates have all been merged/converted to flat YML)