LG-7434: Support HTTP POST for OIDC logout route #10573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
reviewed
May 8, 2024
**Why**: - The specification for OpenID Connect RP-Initiated Logout 1.0 requires both HTTP `GET` and `POST` methods to be supported. See: https://openid.net/specs/openid-connect-rpinitiated-1_0.html#RPLogout - Data sent using the `POST` method remains encrypted during transport in the browser and in web application logs, preventing leakage of sensitive information **How**: - The same endpoint shall be used, `/openid_connect/logout`, but the request data must be sent as part of the body and use form serialization (RFC 9110, sec. 9.3.3) resolves https://gitlab.login.gov/lg-people/lg-people-appdev/protocols/openid-connect/-/issues/3 changelog: Bug Fixes, Security, Support POST for OIDC RP-Initiated Logout 1.0
lmgeorge
force-pushed
the
lmgeorge/LG-7434-add-support-for-post-oidc-logout-requests
branch
from
d9ff5c7
to
756061e
Compare
zachmargolis
approved these changes
May 13, 2024
lmgeorge
deleted the
lmgeorge/LG-7434-add-support-for-post-oidc-logout-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-7434: Add support for POST OIDC logout requests (this ticket has been superseded by the referenced this GitLab issue).
🛠 Summary of changes
GETandPOST. The route definition has been updated with amatchstatementshared_examplesblocks to make working with different request methods simplerindex.html.erbtemplate as been renamed toconfirm_logout.html.erb📜 Testing Plan
Requires:
identity-idpapp to havereject_id_token_hint_in_logout: trueinapplication.ymlOR the partner app must not send anid_token_hintSteps