Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-13171: i18n zh text #10557

Merged
merged 11 commits into from May 21, 2024
Merged

LG-13171: i18n zh text #10557

merged 11 commits into from May 21, 2024

Conversation

dawei-nava
Copy link
Contributor

@dawei-nava dawei-nava commented May 6, 2024

🎫 Ticket

Link to the relevant ticket:
LG-13171

🛠 Summary of changes

zh translations for doc auth.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1: Verify handoff page translation
  • Step 2: Verify selfie tip help center link
  • Step 3: Verify non liveness error warning page and review issue page
  • Step 4: Verify selfie capturing hint texts.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

After:

Hybrid handoff

HybridHandoff

Mobile Capture

Part 1 Part 2 Part 3
MobileCapture1 MobileCapture2 MobileCapture3

Liveness warning, review and help center link text

Warning Review
LivenessWarning LivenessReviewPage

Selfie capture hint

Too small Too close to frame Not found Too many
FaceTooSmallMasked TooCloseToFrameMasked NoFace TooManyFacesMasked

Copy link
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I left a comment about a slight difference that I noticed in line breaks.

@@ -58,47 +58,47 @@
<%# ============== Selfie Section ========== %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code and tested locally. Everything behaved as expected. I did see very slight differences in line breaks on my phone. Maybe the phone I tested with has a different screen width than yours? I tested with a Galaxy.

I don't think this is a blocking concern, but I am including screenshots just in case you are curious.

Screenshot 1:

13171LineBreakScreenshot1

Screenshot 2:

13171LineBreakScreenshot2

Screenshot 3:

13171LineBreakScreenshot3

@dawei-nava dawei-nava force-pushed the dwang/LG-13171_i18n_zh_text branch from e827e1a to 0418497 Compare May 8, 2024 14:54
@dawei-nava dawei-nava marked this pull request as ready for review May 8, 2024 14:58
@dawei-nava dawei-nava changed the title LG-13171: i18n zh text LG-13171: i18n zh text - DO NOT MERGE May 9, 2024
@dawei-nava dawei-nava force-pushed the dwang/LG-13171_i18n_zh_text branch from 0418497 to b41e5ba Compare May 14, 2024 19:28
@daviddsilvanava
Copy link

@dawei-nava i think i didn't see a screen shot of this one? https://docs.google.com/document/d/1CcYTECSulEgZG9tDYyr86Gjp7nxnSw1y4F7JJDcJLcI/edit#bookmark=id.d51d394agknm

but everything else looks good!

@dawei-nava dawei-nava force-pushed the dwang/LG-13171_i18n_zh_text branch 2 times, most recently from 57a0f50 to 8e5893a Compare May 14, 2024 19:30
@dawei-nava dawei-nava force-pushed the dwang/LG-13171_i18n_zh_text branch from 8e5893a to a171c74 Compare May 14, 2024 19:39
@dawei-nava
Copy link
Contributor Author

@dawei-nava i think i didn't see a screen shot of this one? https://docs.google.com/document/d/1CcYTECSulEgZG9tDYyr86Gjp7nxnSw1y4F7JJDcJLcI/edit#bookmark=id.d51d394agknm

but everything else looks good!

That I think we need LG-13117 to be fixed? Right now there is no english text for

Try taking your photos again. Make sure all of your photos are clear and in focus. 

@eileen-nava eileen-nava changed the title LG-13171: i18n zh text - DO NOT MERGE LG-13171: i18n zh text May 21, 2024
@eileen-nava
Copy link
Contributor

@night-jellyfish, @daviddsilvanava, and I reviewed this together on a call after @night-jellyfish and I finished LG-13117. We confirmed the translations are correct. I will now merge in the latest main and then merge this branch after the build passes.

@eileen-nava eileen-nava merged commit 82e5056 into main May 21, 2024
2 checks passed
@eileen-nava eileen-nava deleted the dwang/LG-13171_i18n_zh_text branch May 21, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants