New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-13171: i18n zh text #10557
LG-13171: i18n zh text #10557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. I left a comment about a slight difference that I noticed in line breaks.
@@ -58,47 +58,47 @@ | |||
<%# ============== Selfie Section ========== %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code and tested locally. Everything behaved as expected. I did see very slight differences in line breaks on my phone. Maybe the phone I tested with has a different screen width than yours? I tested with a Galaxy.
I don't think this is a blocking concern, but I am including screenshots just in case you are curious.
e827e1a
to
0418497
Compare
0418497
to
b41e5ba
Compare
@dawei-nava i think i didn't see a screen shot of this one? https://docs.google.com/document/d/1CcYTECSulEgZG9tDYyr86Gjp7nxnSw1y4F7JJDcJLcI/edit#bookmark=id.d51d394agknm but everything else looks good! |
57a0f50
to
8e5893a
Compare
8e5893a
to
a171c74
Compare
That I think we need LG-13117 to be fixed? Right now there is no english text for
|
@night-jellyfish, @daviddsilvanava, and I reviewed this together on a call after @night-jellyfish and I finished LG-13117. We confirmed the translations are correct. I will now merge in the latest main and then merge this branch after the build passes. |
🎫 Ticket
Link to the relevant ticket:
LG-13171
🛠 Summary of changes
zh translations for doc auth.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
After:
Hybrid handoff
Mobile Capture
Liveness warning, review and help center link text
Selfie capture hint