Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agnes/lg 13013 billing report multiple year helper #10556

Merged
merged 21 commits into from May 13, 2024

Conversation

samathad2023
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-13013

🛠 Summary of changes

Added new helper for unique user auth counts by partner.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Unit Test to cover new helper function
  • Negative Test scenarios : empty values and partial month
  • Positive Test scenarios: ial 1 &2 with billable true/false

@ThatSpaceGuy ThatSpaceGuy marked this pull request as ready for review May 11, 2024 19:40
@ThatSpaceGuy ThatSpaceGuy force-pushed the agnes/lg-13013-billing_report_multiple_year_helper branch from 48cd2bc to 8642c31 Compare May 13, 2024 01:08
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! some small comments but this is ready to go! Nice work

@ThatSpaceGuy ThatSpaceGuy merged commit 95e1cd1 into main May 13, 2024
2 checks passed
@ThatSpaceGuy ThatSpaceGuy deleted the agnes/lg-13013-billing_report_multiple_year_helper branch May 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants