New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-12693 How to verify biometric design updates #10524
LG-12693 How to verify biometric design updates #10524
Conversation
…93-how-to-verify-biometric-design-content-updates
…to Verify view conditionally for biometrics
@rutvigupta-design There are 8 screenshots in the description above. Let me know what you think. Thank you! |
@gina-yamada @carmenrosalop will review the screenshots for design! |
…93-how-to-verify-biometric-design-content-updates
@carmenrosalop I added the margin to the tag. There are screenshots in the description. It is ready for a review. Thank you! |
Hey @gina-yamada this is looking great. I noticed that I'm seeing some discrepencies from the design on mobile: |
@JackRyan1989 You are right about that. My changes in this file added a tag and did not change the mobile design/layout. This PR is actually where the mobile designs don't match the Figma mocks. There is a screenshot of mobile on the pull request- you can see it was how it is today and not what was on the mocks. I fixed the spacing a little (see screenshot directly above in the comments section) since you viewed. I wrote up a new ticket to handle the template change because it is out of scope for this ticket. Plus, this ticket should go in asap so that it is in when biometrics go's live. Let me know if you strongly disagree. New ticket: How To Verify- Update Mobile View to Match Mocks |
Yeah I don't think this a stop the pressed kinda thing. Thanks for making the new ticket. |
@carmenrosalop Hi Carmen! There are screenshots in the comments section above along with the new ticket. Please have a review and let me know if you approve as is. Thank you |
…93-how-to-verify-biometric-design-content-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The distance between the icons and content in mobile is a bit off, but @gina-yamada will make an update in this ticket https://cm-jira.usa.gov/browse/LG-13315 so we can close the current PR
…93-how-to-verify-biometric-design-content-updates
🎫 Ticket
LG-12693 Implementation: How to verify biometric design updates
🛠 Summary of changes
📜 Testing Plan
in_person_proofing_opt_in_enabled
is set to true anddoc_auth_selfie_capture_enabled
flag is set to false in config.application.yml and start identity-idp locally/verify/how_to_verify
doc_auth_selfie_capture_enabled
flag to true.localhost:3000/test/oidc/login
/verify/how_to_verify
👀 Screenshots
Screenshots take on 05/13/24 are below in the comments. Those are most recent to see UI (English only)- icon relative to tag/h2.
CURRENT AS OF 05/08/24.
Non Selfie Section: English
Selfie Section: English
Non Selfie Section: Spanish
Selfie Section: Spanish
Non Selfie Section: French
Selfie Section: French
Non Selfie Section: Chinese
Selfie Section: Chinese
Screenshots directly below are outdated as translations have been updated. I am keeping screenshots in to show the changes from pulling in main for history.
OUTDATED - Non Selfie Section: English
OUTDATED - Selfie Section: English
OUTDATED - Non Selfie Section: Spanish
OUTDATED - Selfie Section: Spanish
OUTDATED - Non Selfie Section: French
OUTDATED - Selfie Section: French
OUTDATED - Non Selfie Section: Chinese
OUTDATED - Selfie Section: Chinese