Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-12693 How to verify biometric design updates #10524

Merged

Conversation

gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Apr 29, 2024

🎫 Ticket

LG-12693 Implementation: How to verify biometric design updates

🛠 Summary of changes

  • Added conditional text, tag, and icon for the biometric flow.
  • Conditional text in 4 languages

📜 Testing Plan

  • Step 1 Start identity-oidc-sintatra locally
  • Step 2 Ensure in_person_proofing_opt_in_enabled is set to true and doc_auth_selfie_capture_enabled flag is set to false in config.application.yml and start identity-idp locally
  • Step 3 Visit localhost:9292
  • Step 4 Pick identity-verified for Level of Service and Sign in
  • Step 5 Move through the app until you get to url /verify/how_to_verify
  • Step 6 Inspect page to ensure original view (text, icon, no tag) still persists for the non- biometric flow. You can review DOS translations here, or inspect dev or main side by side this branch. Check English, Spanish, French, and Chinese.
  • Step 7 Stop both servers.
  • Step 8 Set doc_auth_selfie_capture_enabled flag to true.
  • Step 9 Start only idp and visit localhost:3000/test/oidc/login
  • Step 10 pick biometrics
  • Step 11 Move through the app until you get to url /verify/how_to_verify
  • Step 12 Inspect page to check that the content for biometrics has been updated according to the AC list in LG-12693. Check English, Spanish, French, and Chinese. DOS translations here.

👀 Screenshots

Screenshots take on 05/13/24 are below in the comments. Those are most recent to see UI (English only)- icon relative to tag/h2.

CURRENT AS OF 05/08/24.

Non Selfie Section: English

Screenshot 2024-05-08 at 3 23 19 PM

Selfie Section: English

Screenshot 2024-05-08 at 3 20 28 PM

Screenshot 2024-05-08 at 3 21 25 PM

Non Selfie Section: Spanish

Screenshot 2024-05-08 at 3 23 28 PM

Selfie Section: Spanish

Screenshot 2024-05-08 at 3 20 47 PM

Non Selfie Section: French

Screenshot 2024-05-08 at 3 23 36 PM

Selfie Section: French

Screenshot 2024-05-08 at 3 20 57 PM

Non Selfie Section: Chinese

Screenshot 2024-05-08 at 3 23 47 PM

Selfie Section: Chinese

Screenshot 2024-05-08 at 3 21 04 PM

Screenshots directly below are outdated as translations have been updated. I am keeping screenshots in to show the changes from pulling in main for history.

OUTDATED - Non Selfie Section: English Screenshot 2024-05-02 at 8 06 27 AM
OUTDATED - Selfie Section: English Screenshot 2024-05-02 at 8 11 54 AM
OUTDATED - Non Selfie Section: Spanish Screenshot 2024-05-02 at 8 07 26 AM
OUTDATED - Selfie Section: Spanish Screenshot 2024-05-02 at 8 11 22 AM
OUTDATED - Non Selfie Section: French Screenshot 2024-05-02 at 8 08 13 AM
OUTDATED - Selfie Section: French Screenshot 2024-05-02 at 8 10 53 AM
OUTDATED - Non Selfie Section: Chinese Screenshot 2024-05-02 at 8 08 56 AM
OUTDATED - Selfie Section: Chinese Screenshot 2024-05-02 at 8 10 09 AM

@gina-yamada
Copy link
Contributor Author

@rutvigupta-design There are 8 screenshots in the description above. Let me know what you think. Thank you!

@gina-yamada gina-yamada requested review from a team and svalexander May 2, 2024 14:47
@gina-yamada gina-yamada requested a review from aduth May 2, 2024 15:01
@rutvigupta-design
Copy link

@gina-yamada @carmenrosalop will review the screenshots for design!

@gina-yamada
Copy link
Contributor Author

@carmenrosalop I added the margin to the tag. There are screenshots in the description. It is ready for a review. Thank you!

@gina-yamada gina-yamada requested review from carmenrosalop and removed request for carmenrosalop May 8, 2024 21:35
@JackRyan1989
Copy link
Contributor

Hey @gina-yamada this is looking great. I noticed that I'm seeing some discrepencies from the design on mobile:
Screenshot 2024-05-13 at 1 21 01 PM
The Figma design keeps the text wrapped to the right of the image. The breakpoint is at 640px.

@gina-yamada
Copy link
Contributor Author

gina-yamada commented May 13, 2024

Updated images:

Mobile

Selfie:

Screenshot 2024-05-13 at 11 35 19 AM

Non-selfie:

Screenshot 2024-05-13 at 11 36 30 AM

Desktop

Selfie:

Screenshot 2024-05-13 at 11 35 37 AM

Non-selfie:

Screenshot 2024-05-13 at 11 36 12 AM

@gina-yamada
Copy link
Contributor Author

gina-yamada commented May 13, 2024

Hey @gina-yamada this is looking great. I noticed that I'm seeing some discrepencies from the design on mobile: Screenshot 2024-05-13 at 1 21 01 PM The Figma design keeps the text wrapped to the right of the image. The breakpoint is at 640px.

@JackRyan1989 You are right about that. My changes in this file added a tag and did not change the mobile design/layout. This PR is actually where the mobile designs don't match the Figma mocks. There is a screenshot of mobile on the pull request- you can see it was how it is today and not what was on the mocks. I fixed the spacing a little (see screenshot directly above in the comments section) since you viewed. I wrote up a new ticket to handle the template change because it is out of scope for this ticket. Plus, this ticket should go in asap so that it is in when biometrics go's live. Let me know if you strongly disagree. New ticket: How To Verify- Update Mobile View to Match Mocks

@JackRyan1989
Copy link
Contributor

Hey @gina-yamada this is looking great. I noticed that I'm seeing some discrepencies from the design on mobile: Screenshot 2024-05-13 at 1 21 01 PM The Figma design keeps the text wrapped to the right of the image. The breakpoint is at 640px.

@JackRyan1989 You are right about that. My changes in this file added a tag and did not change the mobile design/layout. This PR is actually where the mobile designs don't match the Figma mocks. There is a screenshot of mobile on the pull request- you can see it was how it is today and not what was on the mocks. I fixed the spacing a little (see screenshot directly above in the comments section) since you viewed. I wrote up a new ticket to handle the template change because it is out of scope for this ticket. Plus, this ticket should go in asap so that it is in when biometrics go's live. Let me know if you strongly disagree. New ticket: How To Verify- Update Mobile View to Match Mocks

Hey @gina-yamada this is looking great. I noticed that I'm seeing some discrepencies from the design on mobile: Screenshot 2024-05-13 at 1 21 01 PM The Figma design keeps the text wrapped to the right of the image. The breakpoint is at 640px.

@JackRyan1989 You are right about that. My changes in this file added a tag and did not change the mobile design/layout. This PR is actually where the mobile designs don't match the Figma mocks. There is a screenshot of mobile on the pull request- you can see it was how it is today and not what was on the mocks. I fixed the spacing a little (see screenshot directly above in the comments section) since you viewed. I wrote up a new ticket to handle the template change because it is out of scope for this ticket. Plus, this ticket should go in asap so that it is in when biometrics go's live. Let me know if you strongly disagree. New ticket: How To Verify- Update Mobile View to Match Mocks

Yeah I don't think this a stop the pressed kinda thing. Thanks for making the new ticket.

@gina-yamada
Copy link
Contributor Author

@carmenrosalop Hi Carmen! There are screenshots in the comments section above along with the new ticket. Please have a review and let me know if you approve as is. Thank you

Copy link

@carmenrosalop carmenrosalop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The distance between the icons and content in mobile is a bit off, but @gina-yamada will make an update in this ticket https://cm-jira.usa.gov/browse/LG-13315 so we can close the current PR

…93-how-to-verify-biometric-design-content-updates
@gina-yamada gina-yamada merged commit 1e635c1 into main May 14, 2024
2 checks passed
@gina-yamada gina-yamada deleted the yamada/lg-12693-how-to-verify-biometric-design-content-updates branch May 14, 2024 19:21
@amirbey amirbey mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants