feat: updated translations for DOS IPP #10428

KeithNava · 2024-04-15T12:16:18Z

🎫 Ticket

Link to the relevant ticket:
LG-13046

🛠 Summary of changes

Translation updates for How to Verify Page

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

Navigate to the how to verify page
Update language to Spanish
Confirm the content changes are being shown
Update the language to French
Confirm the content changes are being shown
Update the language to Simplified Chinese
Confirm the content changes are being shown

gina-yamada · 2024-04-15T20:28:47Z

@KeithNava This should be the link to your review app

config/locales/doc_auth/es.yml

config/locales/forms/es.yml

gina-yamada · 2024-04-16T14:12:13Z

gina-yamada

Translations are updated as I'd expect on the page- see screenshots I added
Checked that all of these references are not used outside of the how to verify page so these changes won't accidentally update content on other pages
Approved but there needs to be several period deleted based on the other translations and where the text appears on the page

gina-yamada · 2024-04-16T14:32:49Z

@KeithNava I do not feel comfortable with the change you pushed up to application.yml. It will turn on our feature flag if this gets merged in without being deleted. I am going to remove my approval until this get resolved. Please reach out when this is ready to reviewed again

rutvigupta-design · 2024-04-16T14:51:20Z

The translations content LGTM but I agree with Gina's feedback re: period consistency in the Spanish translation.

(H1) Elija cómo desea verificar su identidad – this shouldn't have a period
(H2) Verifique su identidad en línea – this shouldn't have a period
(H2) Verifique su identidad en una oficina de correos – this shouldn't have a period
(button) Continúe en línea – this shouldn't have a period
(body copy) Esta opción es mejor si no tiene un teléfono para tomar fotografías de su identificación – this is missing a period

There's also an extra line at the bottom of the help links that I believe shouldn't be there.

Noting that we should not push these changes to prod since we have to get them approved by DOS.

mitchellhenke

Can you add the Chinese translations for the changes in this PR as well?

KeithNava · 2024-04-29T20:44:47Z

Can you add the Chinese translations for the changes in this PR as well?

@mitchellhenke we did plan on doing the Chinese translations in a separate ticket.

rutvigupta-design · 2024-05-15T22:58:35Z

Hi @KeithNava I saw Allison was assigned as a design reviewer for this but since she isn't on the team anymore, I took her off and assigned myself. Please let me know if you need another design review!

svalexander

LGTM

KeithNava · 2024-05-20T18:03:04Z

Spanish Translations

French Translations

Simplified Chinese Translations

@rutvigupta-design

rutvigupta-design

@KeithNava thank you for attaching the screenshots! I noticed a few things that may have gotten caught in between all the merges:

Spanish: The body copy (doc_auth_info.how_to_verify) is missing "en una oficina de correos participante." at the end. What is currently implemented is also missing a period at the end, so let's please make sure that is there as well!
Spanish: The body copy for the verify at a Post Office (doc_auth.info.verify_at_post_office_instruction) is also missing "participante." at the end so it should read " Ingresará la información de su identificación en línea, y verificará su identidad en persona en una oficina de correos participante."

Everything else LGTM!

KeithNava · 2024-05-20T20:34:00Z

@rutvigupta-design Thanks for the review - looks like I had a bad merge conflict. Here's the updated screenshot for the Spanish translations.

rutvigupta-design

This LGTM now! 🎉

KeithNava · 2024-05-21T14:13:13Z

@mitchellhenke @gina-yamada I think the merge is awaiting your approval. Thanks!

gina-yamada · 2024-05-21T16:31:47Z

config/locales/es.yml

 doc_auth.info.verify_at_post_office_instruction_selfie: Ingresará la información de su identificación en línea, y verificará su identidad en persona en una oficina de correos participante.
-doc_auth.info.verify_at_post_office_link_text: Obtenga más información sobre la verificación en persona
+doc_auth.info.verify_at_post_office_link_text: Obtenga más información sobre la verificación en persona.


@KeithNava I am still seeing inconsistencies with punctuation for both doc_auth.info.verify_online_link_text and doc_auth.info.verify_at_post_office_link_text. Translation docs look like all should have a period. See links in the screenshots below. (I am not sure if those where the ones previously added in some case that I suggested to delete. It looks like the translations doc has been cleaned up since so let's use the latest translation doc as the expectations and add them.)

English needs a period for doc_auth.info.verify_at_post_office_link_text and doc_auth.info.verify_online_link_text

Chinese needs a period for doc_auth.info.verify_online_link_text

French and Spanish are looking 👀 good! 💯

@gina-yamada thanks for pointing this out! I double-checked our designs, and looks like the English links don't have periods at the end, so I think the translations we got back might have missed this context and I copied them into our translations doc. @KeithNava I think we'll want to ensure none of the links have periods at the end – I'll make sure our documentation reflects this. Apologies for all the confusion, wires are getting a bit crossed between all the versions of things.

gina-yamada · 2024-05-21T16:43:09Z

config/locales/zh.yml

 doc_auth.info.verify_identity: 我们会要求获得你的个人信息并通过与公共记录核对来验证你的身份。
 doc_auth.info.verify_online_description: 如果你没有移动设备或者无法轻松拍身份证件照片，这一选项更好。
 doc_auth.info.verify_online_description_selfie: 如果你有手机可以拍照，请选择该选项。
-doc_auth.info.verify_online_instruction: 你将拍自己身份证件的照片来完全在网上验证身份。大多数用户都能轻松完成这一流程。
+doc_auth.info.verify_online_instruction: 你将拍身份证件的照片来完全在网上验证身份。大多数用户都能轻松完成这样流程。


@KeithNava Double check doc_auth.info.verify_online_instruction. I can find the previous translation in the translation doc but not this one.

gina-yamada · 2024-05-21T16:44:17Z

spec/i18n_spec.rb

@@ -113,8 +113,6 @@ class BaseTask
        { key: 'errors.messages.blank_cert_element_req', locales: %i[zh] },
        { key: 'event_types.sign_in_notification_timeframe_expired', locales: %i[zh] },
        { key: 'event_types.sign_in_unsuccessful_2fa', locales: %i[zh] },
-        { key: 'forms.buttons.continue_ipp', locales: %i[zh] },
-        { key: 'forms.buttons.continue_remote', locales: %i[zh] },


Good clean up!

gina-yamada

There are two items you will need to fix; punctuation and 1 Chinese translation. I will approve now so you are not waiting for approval after fixing each.

…lations for Opt-in IPP non-biometric

…lations for Opt-in IPP non-biometric for Chinese, French, and Spanish

KeithNava · 2024-05-21T19:11:40Z

@rutvigupta-design @gina-yamada Latest screenshots are below

Spanish Translations

French Translations

Simplified Chinese Translations

rutvigupta-design · 2024-05-21T19:41:19Z

@KeithNava latest screenshots look great to me! 🎉

KeithNava requested review from a team and n1zyy April 15, 2024 12:16

KeithNava force-pushed the keithw/LG-13046-dos-translations-for-opt-in-ipp-non-biometric branch from cadcce9 to 543ea19 Compare April 15, 2024 19:54

gina-yamada reviewed Apr 15, 2024

View reviewed changes

config/locales/doc_auth/es.yml Outdated Show resolved Hide resolved

gina-yamada reviewed Apr 15, 2024

View reviewed changes

config/locales/doc_auth/es.yml Outdated Show resolved Hide resolved

gina-yamada reviewed Apr 15, 2024

View reviewed changes

config/locales/forms/es.yml Outdated Show resolved Hide resolved

gina-yamada self-requested a review April 16, 2024 14:18

svalexander requested review from a team and allis-green and removed request for a team April 16, 2024 14:24

gina-yamada requested changes Apr 16, 2024

View reviewed changes

KeithNava marked this pull request as draft April 16, 2024 14:30

gina-yamada self-requested a review April 16, 2024 14:33

KeithNava force-pushed the keithw/LG-13046-dos-translations-for-opt-in-ipp-non-biometric branch from 6675fbe to 3baa59b Compare April 16, 2024 18:12

KeithNava marked this pull request as ready for review April 29, 2024 17:25

KeithNava force-pushed the keithw/LG-13046-dos-translations-for-opt-in-ipp-non-biometric branch from 378a738 to 8ea06b7 Compare April 29, 2024 18:32

mitchellhenke requested changes Apr 29, 2024

View reviewed changes

mitchellhenke self-requested a review April 29, 2024 21:39

KeithNava force-pushed the keithw/LG-13046-dos-translations-for-opt-in-ipp-non-biometric branch 2 times, most recently from 8f2c6a1 to 8b3cce5 Compare May 7, 2024 18:07

KeithNava force-pushed the keithw/LG-13046-dos-translations-for-opt-in-ipp-non-biometric branch from b952eef to d882633 Compare May 14, 2024 18:17

rutvigupta-design requested review from rutvigupta-design and removed request for allis-green May 15, 2024 22:57

KeithNava force-pushed the keithw/LG-13046-dos-translations-for-opt-in-ipp-non-biometric branch from 44016d4 to 4dff95d Compare May 16, 2024 18:29

svalexander approved these changes May 20, 2024

View reviewed changes

rutvigupta-design reviewed May 20, 2024

View reviewed changes

rutvigupta-design approved these changes May 20, 2024

View reviewed changes

gina-yamada reviewed May 21, 2024

View reviewed changes

gina-yamada self-requested a review May 21, 2024 16:44

gina-yamada approved these changes May 21, 2024

View reviewed changes

mitchellhenke approved these changes May 21, 2024

View reviewed changes

KeithNava added 9 commits May 21, 2024 14:58

changelog: User-Facing Improvements, In-person proofing, update trans…

24fcabd

…lations for Opt-in IPP non-biometric

feat: update configs for review-app

a7fbdba

feat: more updates to configs for review-app

a97d1d3

feat: revert config updates

f521421

feat: update i8n spec for keys that are newly translated

f94f0cf

feat: update translations into new format

77a569f

changelog: User-Facing Improvements, In-person proofing, update trans…

87b30b4

…lations for Opt-in IPP non-biometric for Chinese, French, and Spanish

fix: spanish translations fixes from merge conflict

622ddba

feat: code review comments

2ebca51

KeithNava force-pushed the keithw/LG-13046-dos-translations-for-opt-in-ipp-non-biometric branch from bf21979 to 2ebca51 Compare May 21, 2024 18:58

KeithNava merged commit f50fcc8 into main May 21, 2024
2 checks passed

KeithNava deleted the keithw/LG-13046-dos-translations-for-opt-in-ipp-non-biometric branch May 21, 2024 20:42

matthinz mentioned this pull request May 23, 2024

Deploy RC 382 to Production #10692

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: updated translations for DOS IPP #10428

feat: updated translations for DOS IPP #10428

KeithNava commented Apr 15, 2024 •

edited by svalexander

gina-yamada commented Apr 15, 2024

gina-yamada commented Apr 16, 2024

gina-yamada left a comment •

edited

gina-yamada commented Apr 16, 2024 •

edited

rutvigupta-design commented Apr 16, 2024

mitchellhenke left a comment

KeithNava commented Apr 29, 2024

rutvigupta-design commented May 15, 2024

svalexander left a comment

KeithNava commented May 20, 2024

rutvigupta-design left a comment

KeithNava commented May 20, 2024

rutvigupta-design left a comment

KeithNava commented May 21, 2024

gina-yamada May 21, 2024 •

edited

rutvigupta-design May 21, 2024 •

edited

gina-yamada May 21, 2024

gina-yamada May 21, 2024

gina-yamada left a comment

KeithNava commented May 21, 2024

rutvigupta-design commented May 21, 2024

feat: updated translations for DOS IPP #10428

feat: updated translations for DOS IPP #10428

Conversation

KeithNava commented Apr 15, 2024 • edited by svalexander

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

gina-yamada commented Apr 15, 2024

gina-yamada commented Apr 16, 2024

gina-yamada left a comment • edited

Choose a reason for hiding this comment

gina-yamada commented Apr 16, 2024 • edited

rutvigupta-design commented Apr 16, 2024

mitchellhenke left a comment

Choose a reason for hiding this comment

KeithNava commented Apr 29, 2024

rutvigupta-design commented May 15, 2024

svalexander left a comment

Choose a reason for hiding this comment

KeithNava commented May 20, 2024

rutvigupta-design left a comment

Choose a reason for hiding this comment

KeithNava commented May 20, 2024

rutvigupta-design left a comment

Choose a reason for hiding this comment

KeithNava commented May 21, 2024

gina-yamada May 21, 2024 • edited

Choose a reason for hiding this comment

rutvigupta-design May 21, 2024 • edited

Choose a reason for hiding this comment

gina-yamada May 21, 2024

Choose a reason for hiding this comment

gina-yamada May 21, 2024

Choose a reason for hiding this comment

gina-yamada left a comment

Choose a reason for hiding this comment

KeithNava commented May 21, 2024

rutvigupta-design commented May 21, 2024

KeithNava commented Apr 15, 2024 •

edited by svalexander

gina-yamada left a comment •

edited

gina-yamada commented Apr 16, 2024 •

edited

gina-yamada May 21, 2024 •

edited

rutvigupta-design May 21, 2024 •

edited