Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gzip_vary to on to enable cli clients #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sharms
Copy link

@sharms sharms commented Mar 14, 2018

This may need to be explicitly defined, and could potentially cause CLI clients such as wget / curl to not be able to download csv files. I would recommend deploying this to dev and using 'wget' against it to check if the setting works.

It is recommended to switch to the nginx buildpack: https://github.com/cloudfoundry/nginx-buildpack but this might be a good temporary fix while the new buildpack matures .

jmhooper
jmhooper previously approved these changes Mar 14, 2018
@jmhooper
Copy link
Member

I'll test this out later this evening to see how it looks and merge if we're 👍

@konklone
Copy link
Contributor

konklone commented Mar 16, 2018

I see the same thing. But I also don't see a Vary: Accept-Encoding header at all on the response:

$ curl --head https://analytics-staging.app.cloud.gov/data/live/realtime.json
HTTP/1.1 200 OK
Accept-Ranges: bytes
Cache-Control: max-age=0
Cache-Control: no-cache
Content-Encoding: gzip
Content-Length: 253
Content-Type: application/json
Date: Fri, 16 Mar 2018 17:44:41 GMT
Etag: "667bd6bb7e55492bb816be7534f0b8cc"
Last-Modified: Fri, 16 Mar 2018 17:42:52 GMT
Pragma: no-cache
Strict-Transport-Security: max-age=31536000
X-Content-Type-Options: nosniff
X-Frame-Options: DENY
X-Vcap-Request-Id: 0f84e473-5a15-46e3-6e32-4faa1c8bb48e
X-XSS-Protection: 1; mode=block
Connection: keep-alive

@sharms
Copy link
Author

sharms commented Mar 22, 2018

Were there any updates on troubleshooting for this?

@konklone
Copy link
Contributor

@sharms No, I just did some online research about it and can't find anything that would suggest why this isn't working. Are there any known issues with Cloud.gov overriding certain nginx flags or interfering with certain headers?

@jmhooper How sure are you that this fully deployed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants