feat: adapt to voila-sepal-ui template. #909 #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@12rambau, I came up with a simpler solution for the full screen that doesn't require to use the vuetify template, and works well in both scenarios. |
12rambau
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #909.
There are only few changes that I had to do. As I reported in widgetti/ipyvuetify#308,
VuetifyTemplatesdon't have ametadata_idand is not possible to identify them on a straighforward way, that's why I added aclasstag to the main scripts we are using "copy to clipboard" and "fullscreen" for maps, in this way they will be displayed in the DOM when usingdisplaymethod.I didn't set this tag to the other styles and js's we have here because they are obsolete within the new template.
update 04-10-24
Actually, I simplified the full screen event by just adding/removing a css class, that will make the trick work and we'll use less code.