Skip to content

Commit

Permalink
✨ If an openUrl() call receives an object with a render proeprty …
Browse files Browse the repository at this point in the history
…set to false, no render will be performed
  • Loading branch information
skerit committed Nov 14, 2023
1 parent 3f1b66b commit e1cd6e0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Cancel previous render when a new one is started of a custom element
* Implement bracket notation property accessor
* If an `openUrl()` call receives an object with a `render` proeprty set to false, no render will be performed

## 2.3.14 (2023-10-15)

Expand Down
6 changes: 5 additions & 1 deletion lib/client/scene.js
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ Scene.setMethod(function fetch(href, options, callback) {
*
* @author Jelle De Loecker <jelle@develry.be>
* @since 0.0.1
* @version 2.3.14
* @version 2.3.15
*
* @param {String} href The url to go to
* @param {Object} options Options
Expand Down Expand Up @@ -611,6 +611,10 @@ Scene.setMethod(function openUrl(href, options, callback) {
result.variables = variables;
}

if (result.render === false) {
return finishUp(null, result);
}

that.handleServerResponse(url, options, result, req_pledge.request).done(finishUp);
} else {
finishUp(null, result);
Expand Down

0 comments on commit e1cd6e0

Please sign in to comment.