🐛 Fix setting value property on a <select> item not changing the …

…selected option
11ways · Mar 3, 2024 · 68b5e2f · 68b5e2f
1 parent 94c8c0b
commit 68b5e2f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 2.3.19 (WIP)
+
+* Fix setting `value` property on a `<select>` item not changing the selected option
+
 ## 2.3.18 (2024-02-25)
 
 * Add `setGlobal`, `getGlobal` and `hasGlobal` methods to the `Hawkejs` class, for setting "global" variables that are available to all templates

diff --git a/lib/dom/html_element.js b/lib/dom/html_element.js
@@ -186,7 +186,7 @@ Element.setProperty(function tabIndex() {
  *
  * @author   Jelle De Loecker <jelle@develry.be>
  * @since    1.3.0
- * @version  2.3.16
+ * @version  2.3.19
  *
  * @type     {String}
  */
@@ -215,6 +215,20 @@ Element.setProperty(function value() {
 		}
 
 		this.textContent = value;
+	} else if (this.tagName == 'SELECT') {
+		let options = this.querySelectorAll('option'),
+		    option,
+		    i;
+
+		for (i = 0; i < options.length; i++) {
+			option = options[i];
+
+			if (option.value == value) {
+				option.selected = true;
+			} else {
+				option.selected = false;
+			}
+		}
 	} else {
 		if (HAS_VALUE[this.tagName]) {
 			return this.setAttribute('value', value);

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
 	"name": "hawkejs",
 	"description": "Asynchronous Embedded JavaScript templates",
-	"version": "2.3.18",
+	"version": "2.3.19-alpha",
 	"author": "Jelle De Loecker <jelle@elevenways.be>",
 	"keywords": [
 		"template",