This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Updated runValidators function #648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check for an "is-custom" parameter to bypass validation checks on the field itself, within the runValidators function, in case we need it for an advanced custom rule. Changes were made so that we can have a solution for the following scenario: there are two fields, f1 that doesn't have a required parameter and f2 and we want to show an error under f1 if neither fields are valid from the app logic perspective.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for an "is-custom" parameter to bypass validation checks on the field itself, within the runValidators function, in case we need it for an advanced custom rule.
Changes were made so that we can have a solution for the following scenario: there are two fields, f1 that doesn't have a required parameter and f2 and we want to show an error under f1 if neither fields are valid from the app logic perspective.