-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the "context deadline exceeded" issue. #46
Conversation
Hey, thanks for the PR, I will check it this week, but at first glance should not cause any harm. I will get back to you. Sorry for the delay. |
@0x111 Hello ! The image is no more working for me and testing this PR, it fixes the issue for me as well. |
Hi, did you also confirm this PR helps with an error? Because technically there is no functional or dramatic change. Thanks |
I executed
Then waited for 15 minutes at least, it dit not wake it up Then I built my own image with this PR and ran it:
instead of
I see now:
And then a few minutes later the instance was no more hibernating so to me it looks like it is not just cosmetic change ? |
Thanks for your input I was asking because the original poster did later write that it did not work all the time. So thanks for this I will check it this week |
It works constantly now! With the changes that I did in this PR the instance always wakes up when running the container. |
Fix the GLIBC errors due to the new OS version used by latest golang docker image. Error message: /app/servicenow-instance-wakeup: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /app/servicenow-instance-wakeup) /app/servicenow-instance-wakeup: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /app/servicenow-instance-wakeup)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it, there was an issue with using the latest golang Docker image, with GLIBC, I modified the dockerfile to address this issue.
Now this looks fine to me, I will release a new version today.
Sorry for the long delay.
New docker version published on docker hub and github packages too. Thanks for your help @gu-does-git @vdesabou! I appreciate it and I will try my best to react faster to future issues. |
This pull request addresses the "context deadline exceeded" issue that was occurring during the last step of the process. The issue could not be consistently reproduced, but I've included relevant logs to provide context.
The "context deadline exceeded" error was occurring intermittently during the last step of the process, causing the process to fail unpredictably.
Last leg of the logs:
I've identified a similar issue and solution from chromedp/chromedp#1170 and applied it. And now it seems to work fine! (I could only test it once, but I can try testing it multiple times and observing if it works every single time)
edit: I've been testing it for some days now and it has worked every single time 馃槈
Additional Notes:
I had to modify the Makefile so that I could build it locally in my machine (added the CGO_ENABLED=0 flag to the go build command).