Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commands to operate the NFT config contract #307

Open
wants to merge 1 commit into
base: sprint-1.11
Choose a base branch
from
Open

Add commands to operate the NFT config contract #307

wants to merge 1 commit into from

Conversation

peterlimg
Copy link
Member

@peterlimg peterlimg commented Sep 7, 2023 •
edited

A brief description of the changes in this PR:

Add commands to call NFT Config contracts:

  • setUint256
  • getUint256
  • setAddress
  • getAddress

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

dabasov
dabasov approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterlimg @dabasov