New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refreshing Documentation #612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, @gauryvg98. Thanks. Just a couple of points left:
- Please add output response example for
alloc-cancel
,alloc-fini
,list-all
,bl-update
,update
, - Please make sure that the command
revoke
works only for --encrypted files as mentioned in the docs. - Please add example to the
list
command using auth ticket - Please re-check the
sync
andget-diff
command by running it locally and make sure it's working as expected. If you already did that, please mention. - Please hide
add
,sync
,get-diff
,stream
,get-mpt
,recent-refs
,reset-blobber-stats
. Add their existing documentation in README.md to internal.md in the root of the repo. - Please move streaming documentation from the README file to internal.md
- Ensure the validity of this statement mentioned in the docs: "If the stake pool cannot be unlocked as it would leave insufficient funds for opened offers, then
sp-unlock
tags the stake pool to be unlocked later." - The command
wp-info
is removed. Please remove all related docs. - It's mentioned that "
wp-unlock
unlocks an expired write pool." Please verify this statement, that we cannot unlock a write pool for an allocation that's not expired (or cancelled). - Please add documentation to
createdir
,decrypt
,get-mpt
,list-all
,rollback
,validator-update
,shutdow-blobber
,shutdown-validator
. Forrollback
I believe you'll need to check the code. Let me know if you need support.
@gauryvg98 Edit for the above comment: please hide |
Tested -
Couldn't test :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.