Fix tokenomics nightly runs #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stewartie4
suggested changes
Nov 12, 2023
| echo "REPO_SNAPSHOTS_BRANCH=$(echo $(([ -z '${{github.event.inputs.repo_snapshots_branch}}' ] && echo '<CURRENT BRANCH WITH FALLBACK TO CURRENT_SPRINT>') || echo '${{github.event.inputs.repo_snapshots_branch}}'))" >> $GITHUB_ENV | ||
|
|
||
| echo "CURRENT_BRANCH=sprint-1.11" >> $GITHUB_ENV | ||
| echo "REPO_SNAPSHOTS_BRANCH=current-sprint" >> $GITHUB_ENV |
There was a problem hiding this comment.
This is the wrong approach.
The existing logic took the repo snapshots branch from user input and used that. If no branch was selected, it fell back to the current sprint.
We shouldn't be hardcoding runs to a specific sprint or branch as they will diverge quickly
what are you trying to do?
There was a problem hiding this comment.
We want nightly runs on sprint branches. How should I achieve that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.