Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

single Init function and states of SDK in core package #1384

Open
wants to merge 17 commits into
base: sprint-1.13
Choose a base branch
from

Conversation

storybehind
Copy link
Collaborator

@storybehind storybehind commented Feb 1, 2024

Changes

  • Provide a single Init function and maintain the states of SDK in core/client package
  • Refactor zcncore package to use these function, states and mark appropriate functions as Deprecated to indicate to the users of SDK.

Fixes

  • No Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@storybehind storybehind changed the base branch from staging to sprint-1.13 February 10, 2024 14:07
@storybehind storybehind changed the title provide central init function, global config, global container single Init function and states of SDK in core package Feb 11, 2024
@storybehind storybehind marked this pull request as ready for review February 13, 2024 16:11
core/client/set.go Outdated Show resolved Hide resolved
winsdk/sdk.go Outdated Show resolved Hide resolved
zcncore/wallet_base.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant