New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
single Init function and states of SDK in core package #1384
Open
storybehind
wants to merge
17
commits into
sprint-1.13
Choose a base branch
from
refactor-zcncore
base: sprint-1.13
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storybehind
changed the title
provide central init function, global config, global container
single Init function and states of SDK in core package
Feb 11, 2024
3 tasks
storybehind
requested review from
peterlimg,
dabasov and
guruhubb
as code owners
February 13, 2024 16:11
storybehind
commented
Feb 14, 2024
storybehind
commented
Feb 14, 2024
storybehind
commented
Feb 14, 2024
storybehind
commented
Feb 14, 2024
storybehind
commented
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
core/client
packagezcncore
package to use these function, states and mark appropriate functions asDeprecated
to indicate to the users of SDK.Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):