Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature blobber authorization #1389

Closed
wants to merge 31 commits into from
Closed

Conversation

Jayashsatolia403
Copy link
Collaborator

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Jayashsatolia403 Jayashsatolia403 linked an issue Feb 17, 2024 that may be closed by this pull request
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

Attention: Patch coverage is 9.75610% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 14.45%. Comparing base (dc9d4c4) to head (4874b2e).

Files Patch % Lines
code/go/0chain.net/blobbercore/handler/handler.go 16.00% 20 Missing and 1 partial ⚠️
...e/go/0chain.net/blobbercore/handler/auth_ticket.go 0.00% 11 Missing ⚠️
code/go/0chain.net/core/common/admin.go 0.00% 4 Missing ⚠️
code/go/0chain.net/blobber/http.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1389      +/-   ##
===========================================
- Coverage    14.46%   14.45%   -0.01%     
===========================================
  Files          177      178       +1     
  Lines        19895    19936      +41     
===========================================
+ Hits          2878     2882       +4     
- Misses       16657    16693      +36     
- Partials       360      361       +1     
Flag Coverage Δ
Unit-Tests 14.45% <9.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants