Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate sig #1362

Open
wants to merge 14 commits into
base: sprint-1.12
Choose a base branch
from
Open

Aggregate sig #1362

wants to merge 14 commits into from

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Jan 3, 2024

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber feat/aggregate-sig
authorizer
0box
0dns

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (3402040) 23.50% compared to head (5ac7041) 14.38%.

Files Patch % Lines
...e/go/0chain.net/blobbercore/challenge/challenge.go 0.00% 18 Missing ⚠️
code/go/0chain.net/core/common/handler/worker.go 0.00% 16 Missing ⚠️
code/go/0chain.net/blobbercore/challenge/worker.go 0.00% 13 Missing ⚠️
code/go/0chain.net/core/encryption/keys.go 13.33% 12 Missing and 1 partial ⚠️
code/go/0chain.net/blobbercore/challenge/entity.go 0.00% 7 Missing ⚠️
...de/go/0chain.net/blobbercore/challenge/protocol.go 0.00% 5 Missing ⚠️
...ain.net/validatorcore/storage/challenge_handler.go 0.00% 3 Missing ⚠️
code/go/0chain.net/validatorcore/storage/models.go 62.50% 1 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           sprint-1.12    #1362      +/-   ##
===============================================
- Coverage        23.50%   14.38%   -9.13%     
===============================================
  Files               87      177      +90     
  Lines            10196    19912    +9716     
===============================================
+ Hits              2397     2865     +468     
- Misses            7502    16689    +9187     
- Partials           297      358      +61     
Flag Coverage Δ
Unit-Tests 14.38% <8.23%> (-9.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hitenjain14 Hitenjain14 marked this pull request as ready for review January 4, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants