Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding extra unit tests for DistributeRewards #3256

Open
wants to merge 28 commits into
base: sprint-1.15
Choose a base branch
from
Open

Adding extra unit tests for DistributeRewards #3256

wants to merge 28 commits into from
+487 −11

Conversation

shohan2001
Copy link
Collaborator

@shohan2001 shohan2001 commented Apr 23, 2024 •
edited

Solves #3215

@shohan2001 shohan2001 marked this pull request as draft April 23, 2024 18:15
@shohan2001 shohan2001 self-assigned this Apr 23, 2024
@shohan2001 shohan2001 changed the base branch from staging to sprint-1.14 April 23, 2024 18:18
@shohan2001 shohan2001 marked this pull request as ready for review April 30, 2024 12:26
@Jayashsatolia403 Jayashsatolia403 linked an issue May 1, 2024 that may be closed by this pull request
Add coverage for 0 and 100% service charge in DistributeRewards and DistributeRewardsN functions in unit tests #3215
Open
Jayashsatolia403
Jayashsatolia403 approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@Jayashsatolia403 Jayashsatolia403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shohan2001 shohan2001 changed the base branch from sprint-1.14 to sprint-1.15 May 17, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jayashsatolia403 Jayashsatolia403 Jayashsatolia403 approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@shohan2001 shohan2001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add coverage for 0 and 100% service charge in DistributeRewards and DistributeRewardsN functions in unit tests
2 participants
@shohan2001 @Jayashsatolia403