Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sprint 1.14 benchmark tests #3239

Open
wants to merge 9 commits into
base: sprint-1.14
Choose a base branch
from

Conversation

Zorro30
Copy link
Contributor

@Zorro30 Zorro30 commented Apr 9, 2024

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.27761% with 1181 lines in your changes are missing coverage. Please review.

Project coverage is 25.03%. Comparing base (e4a8e8c) to head (f580828).

❗ Current head f580828 differs from pull request most recent head 2b011d7. Consider uploading reports for the commit 2b011d7 to get more accurate results

Files Patch % Lines
...in.net/smartcontract/storagesc/storage_node_gen.go 34.89% 195 Missing and 27 partials ⚠️
...e/go/0chain.net/smartcontract/storagesc/blobber.go 44.82% 87 Missing and 25 partials ⚠️
...n.net/core/util/entitywrapper/enittywrapper_gen.go 44.50% 98 Missing and 13 partials ⚠️
...chain.net/core/util/entitywrapper/enittywrapper.go 53.59% 57 Missing and 14 partials ⚠️
.../0chain.net/smartcontract/partitions/partitions.go 40.40% 54 Missing and 5 partials ⚠️
...de/go/0chain.net/smartcontract/storagesc/models.go 61.68% 41 Missing and 18 partials ⚠️
...e/go/0chain.net/smartcontract/dbs/event/blobber.go 4.25% 45 Missing ⚠️
...0chain.net/smartcontract/storagesc/storage_node.go 65.07% 40 Missing and 4 partials ⚠️
...o/0chain.net/smartcontract/partitions/partition.go 0.00% 42 Missing ⚠️
...o/0chain.net/smartcontract/storagesc/allocation.go 48.68% 27 Missing and 12 partials ⚠️
... and 31 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3239      +/-   ##
===========================================
- Coverage    28.77%   25.03%   -3.74%     
===========================================
  Files          405      535     +130     
  Lines        67169    81108   +13939     
===========================================
+ Hits         19325    20304     +979     
- Misses       45512    58337   +12825     
- Partials      2332     2467     +135     
Flag Coverage Δ
Unit-Tests 25.03% <42.27%> (-3.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zorro30 Zorro30 changed the base branch from staging to sprint-1.14 April 17, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants