Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do r-3 block finalization #3205

Open
wants to merge 2 commits into
base: sprint-1.14
Choose a base branch
from
Open

Do r-3 block finalization #3205

wants to merge 2 commits into from

Conversation

peterlimg
Copy link
Member

@peterlimg peterlimg commented Mar 26, 2024

Fixes

Changes

  • Change to finalize block when there at least 2 confirmats, i.e r-3.

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@peterlimg peterlimg added the do not merge Do not merge PR label Mar 27, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 28.77%. Comparing base (cedc29e) to head (64f92ef).
Report is 40 commits behind head on sprint-1.14.

Files Patch % Lines
...de/go/0chain.net/chaincore/chain/protocol_round.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           sprint-1.14    #3205      +/-   ##
===============================================
- Coverage        28.79%   28.77%   -0.02%     
===============================================
  Files              405      405              
  Lines            67100    67165      +65     
===============================================
+ Hits             19322    19330       +8     
- Misses           45443    45494      +51     
- Partials          2335     2341       +6     
Flag Coverage Δ
Unit-Tests 28.77% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants