New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix authorizer stake/unstake #3204
base: sprint-1.14
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## sprint-1.14 #3204 +/- ##
===============================================
+ Coverage 28.75% 28.83% +0.07%
===============================================
Files 405 405
Lines 67162 67238 +76
===============================================
+ Hits 19314 19385 +71
+ Misses 45518 45504 -14
- Partials 2330 2349 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
return | ||
} | ||
|
||
err = cstate.WithActivation(balances, "artemis", beforeFunc, afterFunc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will we do with previous records, will we ignore them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 20 authorizers on mainnet, each staked with 10000 ZCN so total of 200K ZCN. For now, the simplest fix is to deploy a temporary SC function in the artemis HF that fixes them in a single txn then remove this SC function in the following HF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dabasov please approve so I can implement it.
Fixes
Changes
Need to be mentioned in CHANGELOG.md?
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):