Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix authorizer stake/unstake #3204

Open
wants to merge 20 commits into
base: sprint-1.14
Choose a base branch
from

Conversation

devyetii
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 28.83%. Comparing base (937c205) to head (b778ad9).
Report is 34 commits behind head on sprint-1.14.

Files Patch % Lines
...ode/go/0chain.net/smartcontract/zcnsc/stakepool.go 0.00% 11 Missing ⚠️
...ode/go/0chain.net/chaincore/chain/state_handler.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           sprint-1.14    #3204      +/-   ##
===============================================
+ Coverage        28.75%   28.83%   +0.07%     
===============================================
  Files              405      405              
  Lines            67162    67238      +76     
===============================================
+ Hits             19314    19385      +71     
+ Misses           45518    45504      -14     
- Partials          2330     2349      +19     
Flag Coverage Δ
Unit-Tests 28.83% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return
}

err = cstate.WithActivation(balances, "artemis", beforeFunc, afterFunc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what will we do with previous records, will we ignore them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 20 authorizers on mainnet, each staked with 10000 ZCN so total of 200K ZCN. For now, the simplest fix is to deploy a temporary SC function in the artemis HF that fixes them in a single txn then remove this SC function in the following HF.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dabasov please approve so I can implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants