-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checker for no transaction cost #3158
Open
shohan2001
wants to merge
9
commits into
sprint-1.14
Choose a base branch
from
fix/overflow_transaction
base: sprint-1.14
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+130
−1
Open
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ab4d571
add corner case for no transaction cost
shohan2001 ef42034
failing block generation
shohan2001 0a42f3a
Merge branch 'staging' into fix/overflow_transaction
shohan2001 e0e9e2d
Adding unit test for block generation
shohan2001 637900d
Merge branch 'staging' into fix/overflow_transaction
shohan2001 b0c05e4
Merge branch 'sprint-1.14' into fix/overflow_transaction
dabasov b3b7ee0
Merge branch 'sprint-1.14' into fix/overflow_transaction
shohan2001 eb65e5b
Merge branch 'sprint-1.14' into fix/overflow_transaction
shohan2001 374e719
Merge branch 'sprint-1.14' into fix/overflow_transaction
shohan2001 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to break here as we do in other places