Add checker for no transaction cost #3158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohan2001
requested review from
peterlimg,
dabasov and
guruhubb
as code owners
dabasov
requested changes
Feb 22, 2024
| @@ -1171,6 +1176,10 @@ func (mc *Chain) generateBlock(ctx context.Context, b *block.Block, | |||
| logging.Logger.Debug("Bad transaction cost", zap.Error(err), zap.String("txn_hash", txn.Hash)) | |||
| break | |||
| } | |||
| if cost == math.MaxInt { | |||
| logging.Logger.Debug("No transaction cost", zap.Error(err), zap.String("txn_hash", txn.Hash)) | |||
| return common.NewError(NoTransactionCost, fmt.Sprintf("No transaction cost for txn %v", txn.Hash)) | |||
There was a problem hiding this comment.
we need to break here as we do in other places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #3115
Changes
Need to be mentioned in CHANGELOG.md?
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):