refactor: AssignOp::UpdateWith → AssignOp::MathUpdate, Ast::UpdateMath → Ast::MathUpdate
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validated with `cargo +1.63 check -p jaq-syn`.
prepare for testing the alternative update-assignment operator on the `null` input value.
jq calls this the "alternative update-assignment operator". note that jq documents the alternation operator as an arithmetic operator and that jaq does not internally represent the alternation operator as a math operator. jq 1.6 considers chained `//=` operators without parentheses a syntax error, like with `|=`; jaq allows chained `//=` operators by binding to the right, at the same precedence as `|=`.
rename them to `MathUpdate` to be more consistent with other names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is a patch stack on top of #142, which should be read first. Do not squash these commits.
Rename
UpdateWith&UpdateMathtoMathUpdate, as mentioned in #142.Additionally, extract
LogicOp, which already partially exists in the definition ofAst::Logic(Logic(Id, bool, Id)).