feat: add support for tokenless v3 #1410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
- Coverage 91.29% 90.35% -0.94%
==========================================
Files 4 4
Lines 310 311 +1
Branches 85 84 -1
==========================================
- Hits 283 281 -2
- Misses 25 30 +5
+ Partials 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -31,7 +31,7 @@ const getGitService = (): string => { | |||
|
|
|||
| const isFork = (): boolean => { | |||
| if ( | |||
| `${context.eventName}` !== 'pull_request' || | |||
| `${context.eventName}` !== 'pull_request' && | |||
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
joseph-sentry
force-pushed
the
joseph/tokenless-v3
branch
from
9a328fc
to
b7e79c8
Compare
| @@ -47,6 +47,7 @@ const isPullRequestFromFork = (): boolean => { | |||
| const getToken = async (): Promise<string> => { | |||
| if (isPullRequestFromFork()) { | |||
| core.info('==> Fork detected, tokenless uploading used'); | |||
| process.env['TOKENLESS'] = context.payload.pull_request.head.label; | |||
There was a problem hiding this comment.
can you in this PR description link to the CLI change that is consuming this?
thomasrockhu-codecov
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that we will detect that if this action is being run from a PR and that PR is from a fork to an upstream repo then we should upload using tokenless, so we will set the TOKENLESS env var so that we can pass the necessary information for the CLI to upload using tokenless
Necessary for: codecov/codecov-cli#434