Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popovers: Rename and move popover-related templates to follow naming convention. #30138

Merged
merged 10 commits into from
May 20, 2024

Conversation

sayamsamal
Copy link
Collaborator

Following our current naming convention, rename and move all popover-related templates to web/templates/popovers/*_popover.hbs.

Fixes: #29785 (comment)

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@sayamsamal sayamsamal changed the title Rename and move popover files popovers: Rename and move popover related templates to follow naming convention. May 20, 2024
@sayamsamal sayamsamal changed the title popovers: Rename and move popover related templates to follow naming convention. popovers: Rename and move popover-related templates to follow naming convention. May 20, 2024
@sayamsamal
Copy link
Collaborator Author

sayamsamal commented May 20, 2024

@timabbott Here is the follow-up PR for #29785 (comment).

@timabbott timabbott merged commit dbebd0d into zulip:main May 20, 2024
7 checks passed
@timabbott
Copy link
Sponsor Member

Nice, merged, thanks @sayamsamal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants