Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

personal_menu: Move the theme switcher above the status settings. #30129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sayamsamal
Copy link
Collaborator

This PR improves the visual layout and resolves the inconsistency caused by having the theme switcher placed between the menu options.

CZO Discussion

Screenshots and screen captures:

Before After
image image
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

This change improves the visual layout and resolves the inconsistency
caused by having the theme switcher placed between the menu options.
@sayamsamal
Copy link
Collaborator Author

sayamsamal commented May 18, 2024

@timabbott this should be a quick merge, only moved some lines of code.

(Edit: There may be some discussion still on the way, so removed the integration label)

@sayamsamal sayamsamal added integration review Added by maintainers when a PR may be ready for integration. and removed integration review Added by maintainers when a PR may be ready for integration. labels May 18, 2024
@zulipbot
Copy link
Member

Heads up @sayamsamal, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants