Condense and extend std.Treap's traversal functionalities. #20002
Conversation
|
I think the error come from me forgetting to |
The core functionalities are now in two general functions `extremeInSubtreeOnDirection()` and `nextOnDirection()` so all the other traversing functions (`getMin()`, `getMax()`, and `InorderIterator`) are all just trivial calls to these core functions. The added two functions `Node.next()` and `Node.prev()` are also just trivial calls to these.
|
Can you add a test for |
Done. |
|
@squeek502 Quite a lot of code is not covered by your previous approval. Mind another look? Thanks. |
jeru
force-pushed
the
master
branch
3 times, most recently
from
3207bf3
to
54c0fb8
Compare
|
@andrewrk This PR has no more action item for me. Just to clarify that I added @nektro as reviewer to see whether she has more feedback after her initial comment. Given how many days passed, I'd count that as "no further comments". Let me know if you have more comments, and if not, merge this PR. Thanks. |
|
Pinging Andrew doesn't automatically prioritize your PR. There is a large PR backlog which ought to be dealt with first - himself or another Zig core team member will get to this PR in time. |
|
@mlugg Sorry for the noise. Didn't know the status. |
The core functionalities are now in two general functions
extremeInSubtreeOnDirection()andnextOnDirection()so all the other traversing functions (getMin(),getMax(), andInorderIterator) are all just trivial calls to these core functions.The added two functions
Node.next()andNode.prev()are also just trivial calls to these.