Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic installation on non default namespaces #2348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j4m3s-s
Copy link

@j4m3s-s j4m3s-s commented Jun 6, 2023

Manifests that are used with the default installation don't have a namespace (so it uses the current context's one).

It's my first time using this software so if it's possible I've misread things ~.

@FxKu
Copy link
Member

FxKu commented Aug 10, 2023

Can you also check other mentions of namespace: default in our example manifests? I think in the same file you changed the role binding is referencing the service account in default namespace. So I guess this has to be updated, too.

Note, these manifests where only meant as an example which users can edit to their own wishes incl. the namespace. But if it makes integration easier we can also remove it, of course.

@FxKu FxKu added this to the 2.0 milestone Aug 10, 2023
@j4m3s-s
Copy link
Author

j4m3s-s commented Aug 11, 2023

Hi @FxKu !
Thanks for replying.

I followed the "quickstart" installation which mentions :

kubectl apply -k github.com/zalando/postgres-operator/manifests

All the concerned manifest by this kustomize installation do not reference the default namespace otherwise.
The only other reference to this serviceAccount is minimal-fake-pooler-deployment.yaml which doesn't mention the namespace either. So it should be all good to merge.

@FxKu FxKu modified the milestones: 1.11.0, 2.0 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Open Questions
Development

Successfully merging this pull request may close these issues.

None yet

2 participants