Remove logicalBackupSchedule pattern spec from the postgresql CRD. #2323
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from the postgresql CRD. The pattern only validates the most basic cron schedules, and fail with the use of intervals, lists, ranges, etc.
bwrobc
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
idanovinda and
hughcapet
as code owners
|
FWIW see here for some attempts to create a comprehensive cron schedule regex. |
|
I don't get what are you trying to achieve here? This is about scheduling pg_dump. Do you really need all the cron flexibility there? Normally, our users use WAL archiving for backups and recovery, and logical backups only if they want to keep backups for a longer time since we use retention with the base backups. So therefore, being able to specify points in time with the schedule is good enough. What requirements do you have? |
|
It's a while ago now, but as I recall I was running a frequent schedule for test purposes and wanted to limit it to office hours on weekdays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern only validates the most basic cron schedules, and fails with the use of intervals, lists, ranges, etc.