feat: Add owner references to all resources #2199
Open
+128
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbegenau
force-pushed
the
feat-498-ownerReferences
branch
from
6a81980
to
47ad395
Compare
mbegenau
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
idanovinda and
hughcapet
as code owners
mbegenau
force-pushed
the
feat-498-ownerReferences
branch
from
47ad395
to
1a91adb
Compare
|
It would be cool to add support for OwnerReferences references. Is there anything that prevents us from adopting this PR? |
|
+1 |
2 similar comments
|
+1 |
|
+1 |
mbegenau
force-pushed
the
feat-498-ownerReferences
branch
from
fb4d2ed
to
cb55d11
Compare
|
+1 |
|
+1 any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the Service and Deployment resource managed by the operator had an OwnerReference linking it to the StatefulSet. Now, all managed resources get an OwnerReference pointing to the Postgresql resource.
Fixes #498.