Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create spec for barnard59 #2217

Closed
wants to merge 3 commits into from
Closed

Create spec for barnard59 #2217

wants to merge 3 commits into from

Conversation

tpluscode
Copy link
Contributor

@withfig-bot
Copy link
Collaborator

withfig-bot commented Dec 28, 2023 •
edited

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@withfig-bot
Copy link
Collaborator

Hello @tpluscode,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@tpluscode
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@tpluscode
Copy link
Contributor Author

recheck

withfig-bot added a commit that referenced this pull request Dec 28, 2023
@withfig-bot
@tpluscode has signed the CLA in #2217
d8b1ec1
grant0417
grant0417 requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@grant0417 grant0417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides a lot of instances of default: "[object Map]"

src/barnard59.ts Outdated
{
name: ["--variable"],
description: "variable key value pairs",
args: { name: "name=value", default: "[object Map]" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely a wrong default.

src/barnard59.ts Outdated
{
name: ["--variable"],
description: "variable key value pairs",
args: { name: "name=value", default: "[object Map]" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

src/barnard59.ts Outdated
{
name: ["--variable"],
description: "variable key value pairs",
args: { name: "name=value", default: "[object Map]" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@tpluscode
Copy link
Contributor Author

tpluscode commented Jan 20, 2024 •
edited

Thank you for the review @grant0417 . As you can see, this was generated...

About the bogus defaults. We have options with custom transforms which build a Map object. The default is an empty map, hence the JavaScript's default string representation that object. I would not like to alter the code to account for fig's autocomplete as it requires additional guards in multiple places to handle a possible undefined value for that option.

What about the linting problems? I can fix some casing but it also complains about display help for command which is generated by commander itself. And I don't know what to do about these which say If X is a single value it should not be enclosed in square brackets. I think that needs fixing in @fig/complete-commander

@withfig-bot
Copy link
Collaborator

Overview

src/barnard59.ts:

Info:

URLs:

  • https://cube.link/latest/shape/standalone-constraint-constraint

@tpluscode
Copy link
Contributor Author

ping @grant0417

@grant0417 grant0417 mentioned this pull request May 30, 2024
Merged
@grant0417
Copy link
Member

Hey @tpluscode, I have updated the @fig/complete-commander package with the fixes for the [object Map] default, can you regenerate your spec and submit again?

@tpluscode
Copy link
Contributor Author

Done @grant0417

@tpluscode
Copy link
Contributor Author

replaced by #2365

I finally got my act together and finished set up of the fig action :)

@tpluscode tpluscode closed this Jun 6, 2024
@withfig withfig locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mschrage mschrage Awaiting requested review from mschrage mschrage is a code owner

@grant0417 grant0417 Awaiting requested review from grant0417 grant0417 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tpluscode @withfig-bot @grant0417