use external camera #419

xAstroBoy · 2024-02-23T16:22:20Z

Fix Enemies Nodes not updating
Fix spider mesh not following the current position & rotation
when not controlling, the spider will use that last position and claim it as it's nest.
add LcHaxCamera and make all mods use that one on phantom mode.
add isDead()

add OnOutsideStatusChange to reset all enemies's NavMesh's searches to not be broken when AI Nodes update.

@winstxnhdw all done.

Summary by CodeRabbit

New Features
- Added movement permission control and sprinting logic for characters.
- Introduced dynamic camera positioning to enhance gameplay experience.
- New classes for controlling characters "Bracken," "Jester," "Manticoil," and "Snare Flea" with unique abilities and camera interactions.
- Implemented a custom camera setup with advanced controls and settings.
- Enhanced possession mechanics with updated conditions and event handling.
- Added phantom mode with enable/disable functionality and improved integration with the game's camera system.
Refactor
- Improved code readability and maintainability in character movement and camera management.
Bug Fixes
- Adjusted camera offset calculations and skill use conditions for a smoother gameplay experience.
Chores
- Updated internal access modifiers and method adjustments for better code organization.

lc-hax/Scripts/Helpers/Players.cs

Co-authored-by: Winston H. <56998716+winstxnhdw@users.noreply.github.com>

…kenController.cs

xAstroBoy · 2024-02-23T16:48:04Z

@winstxnhdw looks solid to me, i have been testing these past 3 hours and got this custom camera to work and preserve hud and the rest, enemies work properly when they go outside, and best of all spider now follows the controller .

… New-Camera

xAstroBoy · 2024-02-23T19:05:06Z

@winstxnhdw with the jester i had to add a new Event , OnPlayerCollision , because for some weird reason the jester wouldn't kill a player if outside, so i fixed that.

EDIT : i checked the other enemies that are inside and replicated their collision system without a check to make sure they work

xAstroBoy · 2024-03-17T17:35:06Z

When you inject while in game, you can see that the colours change slightly. The blur is gone. You could've made it a lot easier for yourself if you just switch back and forth from the new camera and the main camera.

the blur ? you can read how the haxcamera is spawned and is not supposed to get rid of that blur or replace the camera, maybe is another mod or something else.

coderabbitai

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0bc6215 and 275daeb.

Files selected for processing (6)

lc-hax/Scripts/Core/HaxCamera.cs (1 hunks)
lc-hax/Scripts/Helpers/Camera.cs (1 hunks)
lc-hax/Scripts/Modules/PhantomMod.cs (4 hunks)
lc-hax/Scripts/Modules/Possession/PossessionMod.cs (1 hunks)
lc-hax/Scripts/Modules/TriggerMod.cs (3 hunks)
lc-hax/Scripts/Patches/PossessionPatch.cs (1 hunks)

Files skipped from review as they are similar to previous changes (4)

lc-hax/Scripts/Core/HaxCamera.cs
lc-hax/Scripts/Helpers/Camera.cs
lc-hax/Scripts/Modules/PhantomMod.cs
lc-hax/Scripts/Patches/PossessionPatch.cs

Additional comments: 2

lc-hax/Scripts/Modules/TriggerMod.cs (1)

92-92: The integration of GetPossessableEnemy in the Fire method simplifies the logic and improves readability. However, consider profiling this change to ensure it does not introduce performance issues, especially in scenarios with many colliders.

lc-hax/Scripts/Modules/Possession/PossessionMod.cs (1)

13-13: The implementation of the Controller property is appropriate for its intended use, allowing for the dynamic assignment of control logic for possessed enemies.

lc-hax/Scripts/Modules/TriggerMod.cs

coderabbitai · 2024-03-17T17:35:59Z

lc-hax/Scripts/Modules/Possession/PossessionMod.cs

+    void InitCharacterMovement(EnemyAI? enemy = null) {
+        this.CharacterMovementInstance = new GameObject("Hax CharacterMovement");
+        this.CharacterMovementInstance.transform.position = enemy is null ? default : enemy.transform.position;
+        this.CharacterMovement = this.CharacterMovementInstance.AddComponent<CharacterMovement>();
+        this.CharacterMovement.Init();
+
+        if (enemy is not null) {
+            this.CharacterMovement.CalibrateCollision(enemy);
+            this.CharacterMovement.CharacterSprintSpeed = this.SprintMultiplier(enemy);
+        }
+    }


Ensure that CharacterMovement instances are properly disposed of before creating a new one to prevent memory leaks. Consider adding a check to destroy the existing CharacterMovementInstance if it's not null before creating a new one.

+ if (this.CharacterMovementInstance != null) { + Destroy(this.CharacterMovementInstance); + } this.CharacterMovementInstance = new GameObject("Hax CharacterMovement");

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

void InitCharacterMovement(EnemyAI? enemy = null) {

this.CharacterMovementInstance = new GameObject("Hax CharacterMovement");

this.CharacterMovementInstance.transform.position = enemy is null ? default : enemy.transform.position;

this.CharacterMovement = this.CharacterMovementInstance.AddComponent<CharacterMovement>();

this.CharacterMovement.Init();

if (enemy is not null) {

this.CharacterMovement.CalibrateCollision(enemy);

this.CharacterMovement.CharacterSprintSpeed = this.SprintMultiplier(enemy);

}

}

void InitCharacterMovement(EnemyAI? enemy = null) {

if (this.CharacterMovementInstance != null) {

Destroy(this.CharacterMovementInstance);

}

this.CharacterMovementInstance = new GameObject("Hax CharacterMovement");

this.CharacterMovementInstance.transform.position = enemy is null ? default : enemy.transform.position;

this.CharacterMovement = this.CharacterMovementInstance.AddComponent<CharacterMovement>();

this.CharacterMovement.Init();

if (enemy is not null) {

this.CharacterMovement.CalibrateCollision(enemy);

this.CharacterMovement.CharacterSprintSpeed = this.SprintMultiplier(enemy);

}

}

lc-hax/Scripts/Modules/Possession/PossessionMod.cs

winstxnhdw · 2024-03-17T17:43:32Z

Oh, you're right. I am blind.

winstxnhdw · 2024-03-17T17:47:05Z

lc-hax/Scripts/Core/HaxCamera.cs

+        this.HaxCamAudioListener.enabled = true;
+        this.HaxCameraContainer.SetActive(false);
+        this.CustomCamera = newCamera;
+        DontDestroyOnLoad(this.HaxCameraContainer);


Is this necessary? HaxCamera is already set to not destroy on load in Loader.cs right?

the container where the camera is not , the module is , but not the container.

Is it possible to make the container a child of the module?

is best not, because the container is programmed to stalk the player.

Because we the module doesn't stalk the player, we have to expose HaxCameraContainer which is so unnecessary.

lc-hax/Scripts/Core/HaxCamera.cs

winstxnhdw · 2024-03-17T18:05:12Z

lc-hax/Scripts/Core/HaxCamera.cs

+    internal void SetActive(bool active) {
+        if (Helper.StartOfRound is not StartOfRound startOfRound) return;
+        if (Helper.LocalPlayer is not PlayerControllerB player) return;
+        if (player.activeAudioListener is not AudioListener playerlistener) return;
+        if (this.HaxCameraContainer is null) return;
+        if (this.HaxCamAudioListener is not AudioListener haxListener) return;
+        if (this.GetCamera() is not Camera camera) return;
+
+        this.HaxCameraContainer.SetActive(active);
+
+        if (!this.HaxCameraContainer.activeSelf) {
+            playerlistener.enabled = true;
+            startOfRound.audioListener = playerlistener;
+            startOfRound.activeCamera.enabled = true;
+        }
+        else {
+            this.CopyFromCamera(startOfRound.activeCamera.transform, camera, startOfRound.activeCamera);
+            startOfRound.activeCamera.enabled = false;
+            playerlistener.enabled = false;
+            startOfRound.audioListener = haxListener;
+        }
+    }


Is there a reason why this cannot be in OnEnable or OnDisable?

Because the container is disabled, not the manager

I am aware, but it doesn't seem like there would be a problem if we use OnEnable instead. Then we don't have to use the boolean flags.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 275daeb and c5b9e83.

Files selected for processing (2)

lc-hax/Scripts/Core/HaxCamera.cs (1 hunks)
lc-hax/Scripts/Modules/ESPMod.cs (2 hunks)

Files skipped from review as they are similar to previous changes (1)

lc-hax/Scripts/Core/HaxCamera.cs

Additional comments: 2

lc-hax/Scripts/Modules/ESPMod.cs (2)

58-59: The conditional check introduced for rendering grabbable objects based on possession status and enemy type is clear and aligns with the PR objectives. Ensure to verify its impact on gameplay to avoid unintended side effects.

109-109: The addition of a condition to skip rendering for the currently possessed enemy and certain enemy types is consistent with the PR's objectives. Recommend thorough testing to ensure seamless integration with the gameplay experience.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between c5b9e83 and b39c60e.

Files selected for processing (1)

lc-hax/Scripts/Core/HaxCamera.cs (1 hunks)

Files skipped from review as they are similar to previous changes (1)

lc-hax/Scripts/Core/HaxCamera.cs

winstxnhdw · 2024-03-17T19:01:25Z

There's still too many things I want to change. I don't like how DisablePhantom is exposed. Phantom should turn off on it's own and not couple with the camera. I'll continue again next week or the week after that.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between b39c60e and eb7c0f4.

Files selected for processing (2)

lc-hax/Scripts/Core/HaxCamera.cs (1 hunks)
lc-hax/Scripts/Modules/PhantomMod.cs (3 hunks)

Files skipped from review as they are similar to previous changes (2)

lc-hax/Scripts/Core/HaxCamera.cs
lc-hax/Scripts/Modules/PhantomMod.cs

xAstroBoy · 2024-04-28T02:15:00Z

@winstxnhdw just to let you know, im done collabing to your repo trying to follow your strict requirements.

winstxnhdw · 2024-04-28T05:20:08Z

@winstxnhdw just to let you know, im done collabing to your repo trying to follow your strict requirements.

you never really ever did follow any. cheers.

xAstroBoy · 2024-04-28T05:45:40Z

@winstxnhdw just to let you know, im done collabing to your repo trying to follow your strict requirements.

you never really ever did follow any. cheers.

the issue is that you dont know how to accept diverse code styles, i understand readability , but how you do it is too much

winstxnhdw · 2024-04-28T05:54:22Z

I won't argue with you further on this. You probably won't find another maintainer that would bother to refactor your code. All I hope is that you won't keep this attitude at a real job. Also, https://blog.codacy.com/coding-standards

Have a nice week.

xAstroBoy and others added 5 commits February 23, 2024 17:20

use external camera

a1861e7

Remove stuff

458a952

Merge branch 'main' into New-Camera

1514ccc

style: format scripts

17be599

Update LcHaxCamera.cs

954733d

winstxnhdw requested changes Feb 23, 2024

View reviewed changes

lc-hax/Scripts/Helpers/Players.cs Outdated Show resolved Hide resolved

xAstroBoy and others added 7 commits February 23, 2024 17:30

Update lc-hax/Scripts/Helpers/Players.cs

4ac4d9c

Co-authored-by: Winston H. <56998716+winstxnhdw@users.noreply.github.com>

Remove pepega moment

8c6421e

style: format scripts

60dab09

Update LcHaxCamera.cs

319a5ba

style: format scripts

774a57a

Discard changes to lc-hax/Scripts/Modules/Possession/Controllers/Brac…

65ae816

…kenController.cs

Merge branch 'main' into New-Camera

3547b79

xAstroBoy and others added 12 commits February 23, 2024 17:56

Update LcHaxCamera.cs

dffa8e3

Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…

68ac2d4

… New-Camera

Update LcHaxCamera.cs

9380d0d

Update LcHaxCamera.cs

7fa117c

Update LcHaxCamera.cs

e9fc937

Fixes

df7bcba

style: format scripts

2a3101f

Fix jester not killing & bugfixes

454adb4

style: format scripts

d2566ff

Update JesterEnemyController.cs

e1b2689

Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…

54fa508

… New-Camera

style: format scripts

e539a31

xAstroBoy and others added 3 commits February 23, 2024 20:11

Update MaskedController.cs

2d21d4a

style: format scripts

a50f661

Update MaskedController.cs

7a0314c

Merge branch 'main' into New-Camera

778dc4a

coderabbitai bot reviewed Mar 17, 2024

View reviewed changes

winstxnhdw reviewed Mar 17, 2024

View reviewed changes

lc-hax/Scripts/Core/HaxCamera.cs Outdated Show resolved Hide resolved

winstxnhdw reviewed Mar 17, 2024

View reviewed changes

refactor: massively cleaner HaxCamera

c5b9e83

coderabbitai bot reviewed Mar 17, 2024

View reviewed changes

winstxnhdw added 2 commits March 18, 2024 02:53

refactor: certain things need not be copied

b39c60e

refactor: no longer necessary to disable kb and mouse

2a365f3

coderabbitai bot reviewed Mar 17, 2024

View reviewed changes

refactor: remove unnecessary internal

eb7c0f4

coderabbitai bot reviewed Mar 17, 2024

View reviewed changes

winstxnhdw and others added 2 commits March 19, 2024 14:23

feat/docs: set all placeable objects upright

75eb030

Merge branch 'main' into New-Camera

cd1881a

winstxnhdw force-pushed the main branch 3 times, most recently from f1bfe19 to 1411cd1 Compare March 19, 2024 06:28

winstxnhdw added 5 commits March 19, 2024 14:29

Merge branch 'main' into New-Camera

f32b719

Merge branch 'main' into New-Camera

9720f2a

Merge branch 'main' into New-Camera

6bf31e5

Merge branch 'main' into New-Camera

88768fb

Merge branch 'main' into New-Camera

70bbbd8

Merge branch 'main' into New-Camera

1bdbf05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use external camera #419

use external camera #419

xAstroBoy commented Feb 23, 2024 •

edited by coderabbitai bot

xAstroBoy commented Feb 23, 2024

xAstroBoy commented Feb 23, 2024 •

edited

xAstroBoy commented Mar 17, 2024

coderabbitai bot left a comment

coderabbitai bot Mar 17, 2024

winstxnhdw commented Mar 17, 2024

winstxnhdw Mar 17, 2024

xAstroBoy Mar 17, 2024

winstxnhdw Mar 17, 2024

xAstroBoy Mar 17, 2024

winstxnhdw Mar 17, 2024

winstxnhdw Mar 17, 2024 •

edited

xAstroBoy Mar 17, 2024

winstxnhdw Mar 17, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

winstxnhdw commented Mar 17, 2024 •

edited

coderabbitai bot left a comment

xAstroBoy commented Apr 28, 2024

winstxnhdw commented Apr 28, 2024

xAstroBoy commented Apr 28, 2024 •

edited

winstxnhdw commented Apr 28, 2024

use external camera #419

Are you sure you want to change the base?

use external camera #419

Conversation

xAstroBoy commented Feb 23, 2024 • edited by coderabbitai bot

Summary by CodeRabbit

xAstroBoy commented Feb 23, 2024

xAstroBoy commented Feb 23, 2024 • edited

xAstroBoy commented Mar 17, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Mar 17, 2024

Choose a reason for hiding this comment

winstxnhdw commented Mar 17, 2024

winstxnhdw Mar 17, 2024

Choose a reason for hiding this comment

xAstroBoy Mar 17, 2024

Choose a reason for hiding this comment

winstxnhdw Mar 17, 2024

Choose a reason for hiding this comment

xAstroBoy Mar 17, 2024

Choose a reason for hiding this comment

winstxnhdw Mar 17, 2024

Choose a reason for hiding this comment

winstxnhdw Mar 17, 2024 • edited

Choose a reason for hiding this comment

xAstroBoy Mar 17, 2024

Choose a reason for hiding this comment

winstxnhdw Mar 17, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

winstxnhdw commented Mar 17, 2024 • edited

coderabbitai bot left a comment

Choose a reason for hiding this comment

xAstroBoy commented Apr 28, 2024

winstxnhdw commented Apr 28, 2024

xAstroBoy commented Apr 28, 2024 • edited

winstxnhdw commented Apr 28, 2024

xAstroBoy commented Feb 23, 2024 •

edited by coderabbitai bot

xAstroBoy commented Feb 23, 2024 •

edited

winstxnhdw Mar 17, 2024 •

edited

winstxnhdw commented Mar 17, 2024 •

edited

xAstroBoy commented Apr 28, 2024 •

edited