Add detection through DOM elements #4434
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yayuyokitano
added
new-feature
|
For the record, while there is an issue where funkwhale does not load the .controls-row element before web scrobbler tries to set up an observer there, delaying setting up the observer until the element is there does not even fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability for web scrobbler to detect sites through DOM elements.
Seems to be working, but is behaving very weird.
Also funkwhale connector seems to be extremely buggy in general, but I don't think it's connected to this PR?
Still need to do more checking on this and try to figure out why funkwhale isn't working properly.
Closes #1882
Closes #3125