Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Update default order in api runs #7675

Merged
merged 4 commits into from
May 21, 2024

Conversation

thanos-wandb
Copy link
Contributor

@thanos-wandb thanos-wandb commented May 20, 2024

Description

What does the PR do? Include a concise description of the PR contents.

Changes default order of api.runs() to ascending (+created_at) to fix the issue where duplicate runs will be returned in API response. This is happening when new runs are created during paginated requests.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

@thanos-wandb thanos-wandb changed the title Update default order in api runs fix(sdk): Update default order in api runs May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.86%. Comparing base (defdd0d) to head (516977b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7675      +/-   ##
==========================================
+ Coverage   74.26%   75.86%   +1.59%     
==========================================
  Files         500      500              
  Lines       55727    54121    -1606     
==========================================
- Hits        41388    41061     -327     
+ Misses      13931    12651    -1280     
- Partials      408      409       +1     
Flag Coverage Δ
func 41.35% <ø> (+0.05%) ⬆️
system 63.51% <ø> (+0.03%) ⬆️
unit 56.37% <ø> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/apis/public/api.py 85.15% <ø> (ø)

... and 105 files with indirect coverage changes

@thanos-wandb thanos-wandb requested a review from a team as a code owner May 21, 2024 17:03
@thanos-wandb thanos-wandb merged commit 3128507 into main May 21, 2024
32 checks passed
@thanos-wandb thanos-wandb deleted the thanos/dup-api-responses-fix branch May 21, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runs returned by wandb.Api contain duplicates not present on the web app
2 participants